-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes mirror bug when originalHost is excluded #569
Conversation
|
||
}) | ||
}) | ||
|
||
context("without originalHost placeholder", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what the bug that you're solving is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user can use {originalHost}
as a placeholder to include the original url path when specifying a mirror. For example, if the original url is https://artifacts.paketo.io/nginx_1.24.0_linux_x64_jammy_fa1dfe46.tgz
and the mirror is https://user:[email protected]/buildpacks-dependencies/{originalHost}
, then this will translate to https://user:[email protected]/buildpacks-dependencies/artifacts.paketo.io/nginx_1.24.0_linux_x64_jammy_fa1dfe46.tgz
. But if the placeholder is excluded, then the mirror translates to https://user:[email protected]/buildpacks-dependencies/nginx_1.24.0_linux_x64_jammy_fa1dfe46.tgz
@sophiewigmore In the initial change, the mirror url was not properly constructed and did not include the actual dependency archive. For instance, with the following: The initial change only worked correctly if the I also updated the tests because the test urls did not include an appropriate scheme and path |
This is helpful info! thank you |
Also adds tests to makes sure that url path is complete